Skip to content

fix(landing): contain sr-only logos heading to stop phantom root scrollbar#5585

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/enterprise-page-scrollbar
Jul 11, 2026
Merged

fix(landing): contain sr-only logos heading to stop phantom root scrollbar#5585
waleedlatif1 merged 1 commit into
stagingfrom
fix/enterprise-page-scrollbar

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The /enterprise page (and /solutions/*, /workflows) showed a second, real browser-level scrollbar that the home page didn't, causing a page-width shift when navigating between them
  • Root cause: SolutionsLogosRow and PlatformLogosRow wrap a sr-only (position: absolute) <h2> in a <section> with no position: relative, so the heading's containing block falls back to the document root. Its un-offset "static position" (wherever the logos section lands in the page) inflated document.documentElement's scroll height, producing a phantom root scrollbar in addition to the app's normal scroll container
  • Fixed by adding relative to both sections' <section> wrapper — matching the existing convention already used by Features' own sr-only heading
  • Verified against staging: document.documentElement.scrollHeight now equals clientHeight on /enterprise, /solutions/it, and /workflows, matching /; no visual change

Type of Change

  • Bug fix

Testing

Tested manually — ran the dev server, measured document.documentElement.scrollHeight vs clientHeight before/after on /, /enterprise, /solutions/it, /workflows, /tables, and screenshotted the enterprise page to confirm no visual regression.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 11, 2026 1:09am

Request Review

@cursor

cursor Bot commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Small CSS positioning fix on two landing sections with no auth, data, or logic changes.

Overview
Fixes an extra document-level scrollbar on enterprise, solutions, and workflows landing pages (and the width jump when navigating from home) by adding relative to the <section> wrappers in PlatformLogosRow and SolutionsLogosRow.

Those sections use an sr-only <h2> (position: absolute). Without a positioned ancestor, the heading’s containing block was the document root, which inflated document.documentElement scroll height. relative on the section contains the heading, aligned with the existing Features pattern. Comments in both files explain the layout/a11y rationale; no visible UI change.

Reviewed by Cursor Bugbot for commit 3abf221. Configure here.

@waleedlatif1

waleedlatif1 commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator Author

@cursor review

@greptile-apps

greptile-apps Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR contains the hidden logos headings on landing pages.

  • Adds relative to the platform logos section wrapper.
  • Adds relative to the solutions logos section wrapper.
  • Updates the component docs to describe the scrollbar fix.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/sim/app/(landing)/components/platform-page/components/platform-logos-row/platform-logos-row.tsx Adds local positioning to the platform logos section so its hidden heading is contained by the section.
apps/sim/app/(landing)/components/solutions-page/components/solutions-logos-row/solutions-logos-row.tsx Adds local positioning to the solutions logos section so its hidden heading is contained by the section.

Reviews (1): Last reviewed commit: "fix(landing): contain sr-only logos head..." | Re-trigger Greptile

cursor[bot]
cursor Bot reviewed Jul 11, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 3abf221. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR contains the hidden logos headings within their landing-page sections. The main changes are:

  • Added relative to the platform logos section wrapper.
  • Added relative to the solutions logos section wrapper.
  • Expanded the component docs to explain the root scrollbar fix.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/sim/app/(landing)/components/platform-page/components/platform-logos-row/platform-logos-row.tsx Adds local relative positioning to contain the platform logos row hidden heading.
apps/sim/app/(landing)/components/solutions-page/components/solutions-logos-row/solutions-logos-row.tsx Adds local relative positioning to contain the solutions logos row hidden heading.

Reviews (2): Last reviewed commit: "fix(landing): contain sr-only logos head..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit 1c60415 into staging Jul 11, 2026
13 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/enterprise-page-scrollbar branch July 11, 2026 01:11
@waleedlatif1 waleedlatif1 mentioned this pull request Jul 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1